Fix adding ipa-extra-hardware#34
Merged
cityofships merged 2 commits intostackhpc:masterfrom Jun 7, 2021
cityofships:fix-ipa-extra-hardware
Merged
Fix adding ipa-extra-hardware#34cityofships merged 2 commits intostackhpc:masterfrom cityofships:fix-ipa-extra-hardware
cityofships merged 2 commits intostackhpc:masterfrom
cityofships:fix-ipa-extra-hardware
Conversation
Depending on OpenStack release, the location IPA and pip installations is different. This commit aims to detect the location and use it automatically. 83fe980 3805e78 Co-authored-by: Michał Nasiadka <michal@stackhpc.com> Co-authored-by: Bartosz Bezak <bartosz@stackhpc.com> Co-authored-by: Doug Szumski <doug@stackhpc.com>
|
There is now an upstream extra-hardware element in IPA builder: https://github.com/openstack/ironic-python-agent-builder/tree/master/dib/extra-hardware |
Member
Author
|
I've added a note to the README explaining that. This PR should still be useful for Victoria and Ussuri releases though. |
markgoddard
approved these changes
Jun 7, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Depending on OpenStack release, the location of IPA and pip installations is different. This change aims to detect the location and use it automatically. Without it, adding
ipa-extra-hardwareelement in Ussuri and newer releases fails.Some people were already correcting this in the past, hence they are mentioned as co-authors.